Post data.sh img dir bug #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMG_DIR is the new name that isn't implemented yet. IMGDIR is the old name.
Allow both for now. IMG_DIR is the new name that's not fully implemented, and IMGDIR is the old name.
Forgot that config.sh uses IMG_DIR, so had to rename ftp-settings.sh.repo's version to IMAGE_DIR.
linuxkidd
reviewed
Oct 4, 2021
linuxkidd
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set both IMG_DIR (new name) and IMGDIR (old name) in ftp-settings.sh.repo. IMGDIR will go away once all the scripts are updated to use IMG_DIR.
For now, fix the bug in postData.sh where it was using IMG_DIR to have it use IMGDIR.