Renamed MP4DIR to VIDEOS_DIR to match endOfNight.sh expectation #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricClaeys
approved these changes
Oct 4, 2021
There was a problem hiding this comment.
Michael, in my test version of Allsky I changed MP4DIR to VIDEOS_DIR in ftp-settings.sh-repo and endOfNight.sh, and when I made the endOfNight.sh changes a few days ago I forgot to set VIDEOS_DIR back to MP4DIR. Thanks for catching it.
In the next day or so I will do a PR for an updated config.sh.repo and ftp-settings.sh.repo and related scripts where I also changed IMGDIR to IMG_DIR to be consistent with the other names, and changed a couple variables in config.sh.repo to be more meaningful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endOfNight.shwas using a variableVIDEOS_DIRwhich was not defined. Updatedftp-settings.sh.repoto match the expectations ofendOfNight.sh.Resolves #552