-
Notifications
You must be signed in to change notification settings - Fork 185
Opencv detection, Makefile cleanup #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sync to upstream
Reviewing now, just looking to see if I have an old-enough debian machine or if I have to spin up a VM or something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few remarks on the Makefile, the c++ changes seem to work for me on x86_64.
Oh, one more change to Makefile: suggest that the user needs to install |
@ckuethe So, overall, seems like we don't need the
-- this can all be removed? ( I'm pretty sure the answer is yes, just confirming ) |
Indeed, it looks like you can get rid of that #ifdef everywhere. |
Thanks for helping make Allsky better. :) |
Likewise! |
NOTE: I had quite a bit of issue getting the Display() function to compile, but finally got something workable -- although, I've not tested the Display capability. I would love for someone to test the Display code prior to merge. Otherwise, the rest of the code compiles fine on both Raspberry Pi OS based on Debian Buster with OpenCV 3.2.0, as well as Debian Bullseye with OpenCV 4.5.1.
Resolves #508
Resolves #509