Update capture.cpp to log camera serial number and configurable ID field

[EricClaeys]

Fixes #484. Fixes #498
Adds camera ID (for USB 3 cameras) and camera serial number to log output. These will be used in a future update that has different settings for different cameras.

[ckuethe]

Nice. I like where this is going.

[EricClaeys]

Chris, how do I submit a new commit to PR #499 to fix the issues you identified?

[ckuethe]

Not sure how to do that with the web ui, but it's easy at the CLI.

• install git
• check out the source
• create a branch (https://github.com/thomasjacquin/allsky/tree/Camera_ID_serialNumber_plus2fixes)
• make changes
• test changes
• commit changes (git add , git commit)
• push changes (git push)
• make more changes
• push changes (git add, git commit, git push)
• ...
• clean up your local repo (git checkout master, git branch -D whateverbranchyoucreatedforthisparticularchange)

It looks like you have a working branch for this change, so I assume you have git and the allsky source on your Pi. But you don't need to work on your Pi - you could do this inside a VM on your laptop/desktop. Anyway, you just keep committing and pushing changes on that branch until it's ready to be merged.

Github's docs are pretty good:

• https://docs.github.com/en/get-started/quickstart/fork-a-repo
• https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-and-deleting-branches-within-your-repository
• https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews
• https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request
• https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests

Maybe there's something in the github docs about making changes using the github Web UI.

[ckuethe]

@EricClaeys would you be offended if I take over this PR and either try fix it, or close/reject it and make a new PR?

[EricClaeys]

@ckuethe no problem if you want to fix it. I view us as a team all working toward the same goal, so it's not too important to me who does what. Thanks for asking.

@linuxkidd please take a look at my newest capture_RPiHQ.cpp prior to refactoring. It's has many of the same functions as capture.cpp.

Eric

[EricClaeys]

@ckuethe I just got to the hotel room and went ahead and made the fixes

[ckuethe]

The -h/-help/--help behavior looks good now, and my camera is detected and identified. But I get a crash if I run capture with no arguments.

./capture

 ******************************************
 *** Allsky Camera Software v0.8.1 | 2021 ***
 ******************************************

Capture images of the sky with a Raspberry Pi and an ASI Camera

Add -h or --help for available options

Author: Thomas Jacquin - <[email protected]>

Contributors:
-Knut Olav Klo
-Daniel Johnsen
-Yang and Sam from ZWO
-Robert Wagner
-Michael J. Kidd - <[email protected]>
-Chris Kuethe

Segmentation fault (core dumped)

[EricClaeys]

It took me a long time to add the core dump feature, and now you're complaining about it? :-)
Since capture is currently never called with no arguments, you mind if I fix that bug in a future PR?
I think capture should use all the defaults specified in the code if no arguments are given.

[ckuethe]

I'll approve to unblock. I agree that it should do something nice, such as run with sensible defaults or emit the help message when no args are given, but crashing is maybe not the most useful thing.

[ckuethe]

Interesting, The 120MM-S on my roof doesn't seem to support the serial number field.

Sep 29 13:35:56 skycam allsky.sh[3179]: *** WARNING: unable to get serialNumber (16 (ASI_ERROR_GENERAL_ERROR))

That doesn't stop capture from running properly, but I guess we will need to be a little bit careful about assuming that a serial number will be present.

[EricClaeys]

Here’s what the ZWO tech said. I agree we need to gracefully handle cameras without a serial #: Almost all cameras support serial number, except for a few very old cameras. In ASICap, if you can see the SN, that means the camera supports serial number.