unbreak ROI selection #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New exposure mode did not correctly set the capture ROI if the image size was manually specified. It was calling SetROI with a 0x0 window which would cause subsequent captures to fail.
|
Good catch. |
Not exiting with a high error code since it might be a transitory error, or something the user can fix quickly based on the log message.
|
Thomas, this looks good to me. |
thomasjacquin
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New exposure mode did not correctly set the capture ROI if the image size was manually specified. It was calling SetROI with a 0x0 window which would cause subsequent captures to fail.
At least partially fixes #471
cc @EricClaeys