Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some junk characters #470

Merged
merged 3 commits into from
Sep 14, 2021
Merged

remove some junk characters #470

merged 3 commits into from
Sep 14, 2021

Conversation

ckuethe
Copy link
Collaborator

@ckuethe ckuethe commented Sep 12, 2021

Dunno what  is, but it's not a µ. Maybe we should revert to us as an approximation for microseconds and um for micrometers because those are easy to type/display in 7-bit ASCII.

@EricClaeys
Copy link
Collaborator

Thomas,
I suggest NOT merging this. Depending on how the log file is displayed (cat, more, vi, nano, etc.), µs will display as µs or µs. I have a newer version of capture.cpp that does a #define for the value. As @ckuethe said, I suggest we simply use "us". "um" should also be used for the pixel size in micrometers.
Eric

@ckuethe
Copy link
Collaborator Author

ckuethe commented Sep 13, 2021

Hang on a moment, I'll update this to us and um.

@EricClaeys
Copy link
Collaborator

Looks good Chris. Thanks for making the changes.
Suggested change: change the "um" for Pixel Size to "microns", since that's what you see in all the literature for pixel size. Plus, not everyone will know what "um" is (at least I didn't...).

@EricClaeys
Copy link
Collaborator

Thomas, this looks good to me.
Chris, thanks for making the change.

@thomasjacquin thomasjacquin merged commit d7fa25f into AllskyTeam:master Sep 14, 2021
@ckuethe ckuethe deleted the remove_garbage_chars branch September 14, 2021 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants