Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "newexposure" to ZWO config file #453

Merged
merged 9 commits into from
Sep 2, 2021
Merged

Added "newexposure" to ZWO config file #453

merged 9 commits into from
Sep 2, 2021

Conversation

EricClaeys
Copy link
Collaborator

No description provided.

EricClaeys and others added 9 commits August 17, 2021 23:46
It was accidentally left as "1" from my Pi.
This changes goes with the changes to "allsky-website" that automatically creates video thumbnails.
Once people grab the "allsky-website" changes they'll need to create the vidoes/thumnails directory.  Should we move the "Create" and "Fixing" code block to a different shell script that users can invoke, and have install.sh also invoke it?  That should make it easier for non-technical users to create the directory.  The "mkdir" will need to change to "mkdir -p".
Fixes #442 
and adds some additional clarifications.
The "free(line);" was causing the problem.  I must be misreading the getline() man page where it says to free() the line...
When the "capture" program aborts/crashes (versus gracefully exits), the exit code is (usually?) greater than 100.  When that happens, for example due to a bug, there's no reason to let the  allsky service restart since the program will crash again, creating an endless cycle.  allsky.sh notices when the capture program aborts and displays an "Error" image directing the user to look in the log file and fix the problem.  It then stops the service.
capture_RPiHQ.cpp doesn't use ZWO's SDK and doesn't use USB.
@thomasjacquin thomasjacquin merged commit 2d04026 into master Sep 2, 2021
@EricClaeys
Copy link
Collaborator Author

EricClaeys commented Sep 2, 2021 via email

@thomasjacquin
Copy link
Collaborator

@EricClaeys ,

Once I've merged dev into master, the easiest is probably to delete your local dev branch and pull the new one from the repo.

git stash     <-- Stash your changes if you have any outstanding code changes
git branch -D dev    <-- deletes your local dev branch
git fetch     <-- retrieves latest repo changes
git checkout dev      <-- select the dev branch
git pull      <-- pull the branch changes from the repo. This creates your new dev branch
git stash pop       <-- This brings back your changes onto the dev branch

Then you should be good to make new commits on the dev branch.

@bbillp
Copy link

bbillp commented Sep 2, 2021 via email

@EricClaeys
Copy link
Collaborator Author

Bill,
what's in GitHub is a fix for people with version 0.8 that were getting the ASI_ERROR_TIMEOUTs. The fix allows you to turn off the "Version 0.8 Exposure" mode, which then uses the version 0.7 mode. All the other version 0.8 features are still active though.
If you use the GUI you'll want to update it as well as "allsky" since the GUI fix includes that new option - click on "Show Advanced Settings" at the bottom of the page, then look for "Version 0.8 Exposure".
If version 0.8 is currently working for you, you don't need this fix. Unfortunately using the version 0.7 exposure method results in a warmer camera.

@thomasjacquin thomasjacquin deleted the dev branch September 2, 2021 20:57
@bbillp
Copy link

bbillp commented Sep 3, 2021 via email

@EricClaeys
Copy link
Collaborator Author

Bill,
You can just download the changed files - capture.cpp, README.md, and settings_ZWO.json.repo. But if you're more comfortable downloading everything from scratch you can do that, too.
Note that disabling the 0.8 exposure mode (i.e., setting "newexposure" to 0) also disables the "cooler sensor" improvement in 0.8, but for people getting the ASI_ERROR_TIMEOUTs in 0.8, there's no way around that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants