Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -newexposure option based on issue 417 #451

Merged
merged 5 commits into from
Sep 2, 2021
Merged

Add -newexposure option based on issue 417 #451

merged 5 commits into from
Sep 2, 2021

Conversation

linuxkidd
Copy link
Collaborator

Based on code update provided in comment by EricClaeys. This allows reverting back to the 'v7' exposure method fixing issue 417.

Includes README.md documentation of the option.

@EricClaeys
Copy link
Collaborator

Thomas, this looks good to me.
Michael - thanks for making these changes. I have them in a version of capture.cpp that includes many other changes, but isn't quite ready for prime time.

@linuxkidd
Copy link
Collaborator Author

@EricClaeys -- I reworded the help text per your suggestion.

Happy to help ( it's just your code after all )... but, ya, I recognize the struggle for your local testing code being included with a simple workaround. So I thought it'd be good to re-package only the workaround to get it merged quicker.

Thanks for all your efforts on this @EricClaeys (btw, if you use the @ then type someone's github name, it'll tag them in the comment for easier alerting. :) )

Copy link
Collaborator

@thomasjacquin thomasjacquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@thomasjacquin thomasjacquin merged commit 16eee33 into AllskyTeam:master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants