Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing modules #3164

Merged

Conversation

Alex-developer
Copy link
Collaborator

No description provided.

@Alex-developer Alex-developer merged commit 0a651da into AllskyTeam:Point-Release-4 Dec 7, 2023
Copy link
Collaborator

@EricClaeys EricClaeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alex-developer, if I understand this correctly it will set the text for an expired variable to whatever the user specified or to "". Would it be better to use "exp" (or something similar) if the user didn't specify anything? I think that would be more obvious and would be easier to document in a "Troubleshooting" page.

@Alex-developer
Copy link
Collaborator Author

@Alex-developer, if I understand this correctly it will set the text for an expired variable to whatever the user specified or to "". Would it be better to use "exp" (or something similar) if the user didn't specify anything? I think that would be more obvious and would be easier to document in a "Troubleshooting" page.

Could do the intention was not to break any exiting installations. If you would like I will set it to a non blank default value

@EricClaeys
Copy link
Collaborator

@Alex-developer, I think a non-blank default would be less confusing. If you don't mind changing it, I'd appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants