Implement "experimental" exposure mode for ZWO #2731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
EricClaeys
commented
Jun 2, 2023
EricClaeys
commented
- Add an "experimentalExposure" setting for ZWO cameras that when enabled, will use our auto-exposure algorithm at night in addition to daytime.
- Allow the user to set the target mean for daytime and nighttime the same as is done for RPi. This happens even if experimentalExposure is not enabled.
- Allow separate min, max, and default values in the WebUI for day and night.
* Remove "#ifdef HISTOGRAM" - it's always used and will be replaced. * Do more error checking. * Add "experimental" exposure mode that uses our auto-exposure algorithm at night. This works well in limited testing but needs more testing. * Add "useSnapshotMode" for a future addition that uses ZWO's snapshot mode instead of video mode to take a picture. * Modify many Log() message for better troubleshooting. * Change indenting in several places to make code easier to read. * When ping-ponging, add a percent of the number of ping pongs (basically, a unique amount) to the exposure time. Not sure it helps, but try anyhow.
Also, move some lines to match the order in the WebUI
It's now always the array of ints.
Also no need for "else" after "continue"
No need for "else" after "continue"
Also mention default gains.
This matches RPi.
* Split "mean" into "daymean" and "nightmean" since their settings are different. * "Exposure" output to CC file needs to be in ms to match the WebUI. * Add day/night entries whose defaults are different.
The WebUI uses 0.0 to 1.0 (just like with RPi), but our current ZWO auto-exposure algorithm uses 0 to 255.
* [a-z]_min/_max/_default/_display no longer have [a-z]. This makes it less error prone when adding settings. These fields' values are obtained from the fields' CC file entries (if present). * Values for "day_" and "night_" field values get their values from the setting name's entry in the CC file. For example, "dayexposure" and "nightexposure" have different defaults: "day_default" and "night_default", whereas their min and max values are the same.
The "[a-z]_min/_max/_default/_display" values no longer have the "[a-z]" which makes it easier and less error prone when adding settings. When _min/_max/_default/_display are used with a setting whose name begins with "day" or "night", the day and night values are the same in the CC file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.