Skip to content

Commit

Permalink
timelapse.sh: remove filename.sh
Browse files Browse the repository at this point in the history
Also remove unneeded compatibility code
  • Loading branch information
EricClaeys authored Feb 12, 2022
1 parent 1404afa commit 7fd6634
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions scripts/timelapse.sh
Original file line number Diff line number Diff line change
@@ -1,22 +1,12 @@
#!/bin/bash

# TODO: remove these lines once we know they are in the new unified configuration file.
TIMELAPSEWIDTH=${TIMELAPSEWIDTH:-0}
TIMELAPSEHEIGHT=${TIMELAPSEHEIGHT:-0}
FFLOG=${FFLOG:-warning}
FPS=${FPS:-25}
VCODEC=${VCODEC:-libx264}
TIMELAPSE_BITRATE=${TIMELAPSE_BITRATE:-2000k}
PIX_FMT=${PIX_FMT:-yuv420p}

This comment has been minimized.

Copy link
@jpaana

jpaana Feb 15, 2022

Contributor

This variable is not set in default configuration causing ffmpeg to give error due to empty pixel format

This comment has been minimized.

Copy link
@EricClaeys

EricClaeys Feb 15, 2022

Author Collaborator

Which variable? PIX_FMT?

This comment has been minimized.

Copy link
@jpaana

jpaana Feb 15, 2022

Contributor

Yes

This comment has been minimized.

Copy link
@EricClaeys

EricClaeys Feb 16, 2022

Author Collaborator

Update posted. Thanks for reporting the problem.


# Allow this script to be executed manually, which requires ALLSKY_HOME to be set.
if [ -z "${ALLSKY_HOME}" ] ; then
export ALLSKY_HOME="$(realpath $(dirname "${BASH_ARGV0}")/..)"
fi

source "${ALLSKY_HOME}/variables.sh"
source "${ALLSKY_CONFIG}/config.sh"
source "${ALLSKY_SCRIPTS}/filename.sh"

# If we're on a tty that means we're being manually run and $RED != "".
# In that case, don't display $ME.
Expand Down

0 comments on commit 7fd6634

Please sign in to comment.