Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dlc PoseEstimationSeries a DynamicTable #137

Closed
bjhardcastle opened this issue Sep 27, 2024 · 3 comments
Closed

Make dlc PoseEstimationSeries a DynamicTable #137

bjhardcastle opened this issue Sep 27, 2024 · 3 comments
Assignees

Comments

@bjhardcastle
Copy link
Member

It's much easier to use..

Q: Does it make it any more difficult to compress data as a table?

@bjhardcastle
Copy link
Member Author

Let's put this on hold for now - we may not use the side/body DLC anyway.

@bjhardcastle bjhardcastle removed this from the paper1-datacube milestone Sep 27, 2024
@bjhardcastle
Copy link
Member Author

This started crashing so I'm inclined to switch instead of fixing the issue (the message says it's supposedly a warning, but it actually raises an exception):

Traceback (most recent call last):
  File "/code/run.py", line 61, in <module>
    npc_sessions_cache.write_all_components_to_cache(session=session, skip_existing=args.skip_existing)
  File "/code/npc_sessions_cache/src/npc_sessions_cache/utils/cache.py", line 260, in write_all_components_to_cache
    component = _get_nwb_component(session, component_name)
  File "/code/npc_sessions_cache/src/npc_sessions_cache/utils/cache.py", line 92, in _get_nwb_component
    in session.processing["behavior"].fields["data_interfaces"].keys()
  File "/opt/conda/lib/python3.9/site-packages/npc_sessions/sessions.py", line 751, in processing
    module = getattr(self, f"_{module_name}")
  File "/opt/conda/lib/python3.9/site-packages/npc_io/cached_property.py", line 79, in __get__
    val = self.func(instance)
  File "/opt/conda/lib/python3.9/site-packages/npc_sessions/sessions.py", line 776, in _behavior
    modules.extend(self._dlc)
  File "/opt/conda/lib/python3.9/site-packages/npc_io/cached_property.py", line 79, in __get__
    val = self.func(instance)
  File "/opt/conda/lib/python3.9/site-packages/npc_sessions/sessions.py", line 3100, in _dlc
    ndx_pose.pose.PoseEstimation(
  File "/opt/conda/lib/python3.9/site-packages/hdmf/utils.py", line 668, in func_call
    return func(args[0], **pargs)
  File "/opt/conda/lib/python3.9/site-packages/ndx_pose/pose.py", line 268, in __init__
    raise DeprecationWarning(msg)
DeprecationWarning: The number of original videos must equal the number of camera devices. This will become an error in a future release.

@arjunsridhar12345
Copy link
Contributor

yeah sounds good. i guess we just keep it for now then with the switch? (or not use the dlc at all since I don't think its used in the analysis anywhere)

bjhardcastle added a commit that referenced this issue Oct 17, 2024
- unify LP and DLC tables
- cut all but eye DLC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants