Port to use pymc3.sample_prior_predictive#5
Merged
AllenDowney merged 1 commit intoAllenDowney:masterfrom Aug 8, 2018
Merged
Conversation
Owner
|
This is amazing, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had been using this as a test case for pymc-devs/pymc#2983, and thought I would push the changes back up in case they were interesting.
The only changes I made were in code - there are still some comments about PyMC3 not being great at running forwards which (I think!) are no longer true. Also, even if a model has observed variables, you can use
pm.sample_prior_predictive, which may be to avoid repeating code.Thanks again for the useful examples and a great talk!