fix: make main kernel loop range exclusive#30
Merged
ryan-berger merged 1 commit intorberger/cpu-cleanfrom Jan 3, 2026
Merged
Conversation
This reduces the distance searched for in every line of sight by one elevation less. This is more accurate and consistent with other approaches. No changes to viewsheds in tests or benchmarks. But total surfaces are reduced.
tombh
force-pushed
the
tombh/kernel-los-exclusive-range
branch
from
784ed51 to
ae5662e
Compare
ryan-berger
approved these changes
Jan 3, 2026
ryan-berger
pushed a commit
that referenced
this pull request
Jan 9, 2026
This reduces the distance searched for in every line of sight by one elevation less. This is more accurate and consistent with other approaches. No changes to viewsheds in tests or benchmarks. But total surfaces are reduced.
ryan-berger
pushed a commit
that referenced
this pull request
Jan 17, 2026
This reduces the distance searched for in every line of sight by one elevation less. This is more accurate and consistent with other approaches. No changes to viewsheds in tests or benchmarks. But total surfaces are reduced.
ryan-berger
pushed a commit
that referenced
this pull request
Jan 17, 2026
This reduces the distance searched for in every line of sight by one elevation less. This is more accurate and consistent with other approaches. No changes to viewsheds in tests or benchmarks. But total surfaces are reduced.
ryan-berger
pushed a commit
that referenced
this pull request
Jan 17, 2026
This reduces the distance searched for in every line of sight by one elevation less. This is more accurate and consistent with other approaches. No changes to viewsheds in tests or benchmarks. But total surfaces are reduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the distance searched for every line of sight by one less elevation point. This is more accurate and consistent with other approaches.
No changes to viewsheds in tests or benchmarks. But total surfaces are reduced.