Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mac OS CI - usernet unable to resolve IP for SSH forwarding #2556

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

SmartManoj
Copy link
Contributor

@SmartManoj SmartManoj commented Jun 21, 2024

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
Action link

Give a brief summary of what the PR does, explaining any non-trivial design decisions
Enabled --network-address and used the development version of Colima

Other references
docker not listening on port on OSX - colima
abiosoft/colima#458 (comment)

@SmartManoj SmartManoj merged commit f3ba2f0 into All-Hands-AI:main Jun 21, 2024
@SmartManoj SmartManoj deleted the mac2 branch June 21, 2024 04:32
@iFurySt
Copy link
Collaborator

iFurySt commented Jun 21, 2024

Thanks, I hope this can completely resolve the issue❤️

@SmartManoj
Copy link
Contributor Author

hope

Why is hope a dangerous thing?🤣

@tobitege
Copy link
Collaborator

@SmartManoj I think colima still needs more tweaking, even with this patch.
Maybe we have to forcefully first uninstall colima and install it fresh?
It already waits for 3 minutes for the ssh socket file and still fails, so I doubt it is a timeout issue itself.

@SmartManoj
Copy link
Contributor Author

@tobitege
Copy link
Collaborator

Please take a look closer, from a current, successful workflow:

https://github.com/OpenDevin/OpenDevin/actions/runs/9610927108/job/26508440819

grafik

@SmartManoj
Copy link
Contributor Author

SmartManoj commented Jun 21, 2024

Maybe we have to forcefully first uninstall colima and install it fresh?

That's called reinstall. Need to upgrade

actions/runner-images#6216 (comment)

@SmartManoj SmartManoj mentioned this pull request Jun 21, 2024
@tobitege
Copy link
Collaborator

Who said upgrading?

@SmartManoj
Copy link
Contributor Author

Edited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants