Skip to content

build(ds5): pin HIDMaestro to v1.6.2 - #982

Closed
qiin2333 wants to merge 1 commit into
masterfrom
chore/pin-hidmaestro-1.6.2
Closed

build(ds5): pin HIDMaestro to v1.6.2#982
qiin2333 wants to merge 1 commit into
masterfrom
chore/pin-hidmaestro-1.6.2

Conversation

@qiin2333

Copy link
Copy Markdown
Collaborator

Summary

  • Bump the pinned HIDMaestro release from v1.6.1 to v1.6.2 (SHA-256 6ae8df0c…80ff, 118,881,819 bytes) in the sidecar build script, the control-panel installer constants, docs, and i18n install-confirm strings.
  • Upstream v1.6.2 is a drop-in replacement: UMDF2 driver unchanged (DriverVer 1.4.7), no managed API changes — only VR legacy-input bindings. Our alwaysArmed DualSense profile patch is unaffected and still required.

Test plan

  • scripts/build-ds5-sidecar.ps1 downloads and digest-verifies HIDMaestro-v1.6.2.zip against the new pinned hash.
  • Control panel install flow downloads v1.6.2 and passes verification.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a9f7d0b0-23fd-4cde-bbc4-91bf936993e1

📥 Commits

Reviewing files that changed from the base of the PR and between d675952 and e2a4380.

📒 Files selected for processing (6)
  • docs/windows_dualsense_component_lifecycle.md
  • scripts/build-ds5-sidecar.ps1
  • src_assets/common/sunshine-control-panel
  • tools/sunshine-ds5-sidecar/README.md
  • tools/sunshine-ds5-sidecar/SidecarServer.cs
  • tools/sunshine-ds5-sidecar/Sunshine.Ds5Sidecar.csproj

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: Windows
🔇 Additional comments (6)
scripts/build-ds5-sidecar.ps1 (1)

7-8: LGTM!

tools/sunshine-ds5-sidecar/Sunshine.Ds5Sidecar.csproj (1)

13-13: LGTM!

Also applies to: 22-22

tools/sunshine-ds5-sidecar/README.md (1)

7-7: LGTM!

docs/windows_dualsense_component_lifecycle.md (1)

37-37: LGTM!

Also applies to: 649-650

tools/sunshine-ds5-sidecar/SidecarServer.cs (1)

246-246: LGTM!

src_assets/common/sunshine-control-panel (1)

1-1: 🗄️ Data Integrity & Integration

合并子模块指针更新

提交 8cc0230388a3507d55b87acfd6d337ddde15144e 将 HIDMaestro 更新至 v1.6.2,并同步更新下载地址、SHA-256 校验值、安装成功提示和错误提示。旧提交与新提交之间的 7 个提交仅修改 DualSense 相关代码、界面、国际化文本和测试,未发现无关改动。


Summary by CodeRabbit

  • 更新

    • HIDMaestro 运行时升级至 v1.6.2,并同步更新官方发布包、校验摘要及文件大小信息。
    • DualSense 相关构建与运行时提示已同步至新版本。
    • 更新配套组件版本,确保相关功能使用最新内容。
  • 文档

    • 更新 Windows DualSense 生命周期及构建说明,反映 v1.6.2 版本信息。
    • 修正文档中的上游配置问题说明。

Walkthrough

项目将 HIDMaestro 基准版本和运行时引用从 v1.6.1 更新至 v1.6.2,并同步发布包校验信息、文档、错误提示及控制面板子模块指针。

Changes

DualSense 运行时更新

Layer / File(s) Summary
HIDMaestro v1.6.2 版本对齐
scripts/build-ds5-sidecar.ps1, tools/sunshine-ds5-sidecar/..., docs/windows_dualsense_component_lifecycle.md
构建脚本、sidecar 项目配置、README 和生命周期文档统一使用 HIDMaestro v1.6.2。生命周期文档同步更新官方压缩包、SHA-256 摘要和文件大小。
控制面板子模块更新
src_assets/common/sunshine-control-panel
子模块指针更新至提交 8cc0230388a3507d55b87acfd6d337ddde15144e

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to e2a43

This localized dependency pin updates the related download, verification, installer, documentation, and messaging references; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

Suggested reviewers: yundi339

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed 标题准确概括了将 DS5 组件固定到 HIDMaestro v1.6.2 的主要变更。
Description check ✅ Passed 描述说明了 HIDMaestro 版本、校验值、影响范围和测试计划,与变更内容相关。
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/pin-hidmaestro-1.6.2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qiin2333 qiin2333 closed this Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant