Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass ctx in cni call #705

Merged
merged 1 commit into from
Oct 21, 2024
Merged

pass ctx in cni call #705

merged 1 commit into from
Oct 21, 2024

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Oct 21, 2024

replace default log to klog
deprecated vpc route

@l1b0k l1b0k requested a review from BSWANG October 21, 2024 07:00
replace default log to klog
deprecated vpc route

Signed-off-by: l1b0k <[email protected]>
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 23.70690% with 177 lines in your changes missing coverage. Please review.

Project coverage is 19.85%. Comparing base (6a4a716) to head (2d1d7e9).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
plugin/terway/cni_linux.go 0.00% 35 Missing ⚠️
plugin/terway/cni.go 0.00% 31 Missing ⚠️
plugin/driver/utils/netlink_linux.go 6.25% 30 Missing ⚠️
plugin/driver/utils/utils_linux.go 26.82% 28 Missing and 2 partials ⚠️
plugin/driver/utils/utils.go 0.00% 13 Missing ⚠️
plugin/datapath/ipvlan_linux.go 55.55% 11 Missing and 1 partial ⚠️
plugin/datapath/vlan_linux.go 0.00% 8 Missing ⚠️
plugin/datapath/exclusive_eni_linux.go 50.00% 6 Missing ⚠️
plugin/datapath/policy_router_linux.go 58.33% 5 Missing ⚠️
plugin/driver/vlan/vlan.go 0.00% 4 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
- Coverage   20.27%   19.85%   -0.42%     
==========================================
  Files         125      123       -2     
  Lines       17005    16809     -196     
==========================================
- Hits         3447     3338     -109     
+ Misses      13170    13094      -76     
+ Partials      388      377      -11     
Flag Coverage Δ
unittests 19.85% <23.70%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BSWANG BSWANG merged commit 542a887 into AliyunContainerService:main Oct 21, 2024
8 of 9 checks passed
@l1b0k l1b0k deleted the feat/log branch October 21, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants