Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create network interfaces with a dedicated tag #64

Merged
merged 2 commits into from
Sep 23, 2019

Conversation

gaorong
Copy link
Contributor

@gaorong gaorong commented Sep 21, 2019

create network interfaces with a dedicated tag, which can greatly facilitate our life and well itegrate with other systems.
such as:

  • Authorization system (e.g. RAM) can set up some policy based on tags. We trust our code, but we can not guarantee terway 100% bug-free, so we should set up a last defense by authorization policy to avoid terway to delete other people's ENI in some extreme case.
  • We can also manipulate ENIs created by terway via tags: aliyun ecs DescribeNetworkInterfaces --RegionId cn-hangzhou --Tag.1.Key creater --Tag.1.Value terway. this may be helpful when there are lots of ENIs but most of them have no relationship with terway.

@gaorong gaorong changed the title WIP: create network interfaces with a dedicated tag create network interfaces with a dedicated tag Sep 23, 2019
@codecov-io
Copy link

Codecov Report

Merging #64 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #64      +/-   ##
=========================================
- Coverage    6.13%   6.13%   -0.01%     
=========================================
  Files          31      31              
  Lines        3682    3685       +3     
=========================================
  Hits          226     226              
- Misses       3442    3445       +3     
  Partials       14      14
Impacted Files Coverage Δ
pkg/aliyun/ecs.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e098b72...06c12b5. Read the comment docs.

@BSWANG BSWANG merged commit 6814c73 into AliyunContainerService:master Sep 23, 2019
@gaorong gaorong deleted the eni-tag branch September 23, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants