Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix misspell scan failure #44

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

sunyuan3
Copy link
Contributor

@sunyuan3 sunyuan3 commented Jul 2, 2019

Signed-off-by: Yuan Sun [email protected]

@denverdino
Copy link
Contributor

Can we also scan non-ascii char?

@codecov-io
Copy link

codecov-io commented Jul 2, 2019

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #44   +/-   ##
====================================
  Coverage      75%   75%           
====================================
  Files           4     4           
  Lines         264   264           
====================================
  Hits          198   198           
  Misses         52    52           
  Partials       14    14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d1be32...8dbdf99. Read the comment docs.

@sunyuan3
Copy link
Contributor Author

sunyuan3 commented Jul 2, 2019

@denverdino I have a try. The misspell tool can't scan the error of non-ascii char. I need to research other tools.

log: "wrang" is not found.

root@85190ec0146c:/tmp# cat README.md
This is a wrang word.
root@85190ec0146c:/tmp# if LC_ALL=C grep -q '[![:cntrl:][:print:]]' README.md; then   echo "Contain Non-ASCII"; fi
Contain Non-ASCII
root@85190ec0146c:/tmp# misspell -error README.md
root@85190ec0146c:/tmp# echo $?
0

@sunyuan3
Copy link
Contributor Author

sunyuan3 commented Jul 2, 2019

I used the mdspell tool, which can scan non-ascii char for markdown files. However, some custom words are scanned as error, such as terway & aliyun. I have to create a custom dictionary to ignore them.

mdspell:
屏幕快照 2019-07-02 上午11 53 47

@denverdino
Copy link
Contributor

Warning should be fine. Error is too strict. Thanks

@sunyuan3
Copy link
Contributor Author

sunyuan3 commented Jul 2, 2019

@denverdino Could you please review this pull request?

@BSWANG BSWANG merged commit e7c0d0b into AliyunContainerService:master Jul 2, 2019
@BSWANG BSWANG mentioned this pull request Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants