Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Teardown may cause resource leak #294

Merged
merged 1 commit into from
Dec 20, 2021
Merged

fix: Teardown may cause resource leak #294

merged 1 commit into from
Dec 20, 2021

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Dec 13, 2021

In containerd environment , containers cannot be destroyed when cni return err.
This PR can alleviate this situation.

@l1b0k l1b0k added kind/bug Something isn't working kind/enhancement New feature or request labels Dec 13, 2021
@l1b0k l1b0k requested a review from BSWANG December 13, 2021 07:01
@l1b0k l1b0k self-assigned this Dec 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #294 (d506c01) into main (9bd1304) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #294      +/-   ##
========================================
+ Coverage   4.46%   4.48%   +0.02%     
========================================
  Files         98      98              
  Lines       9448    9404      -44     
========================================
  Hits         422     422              
+ Misses      8993    8949      -44     
  Partials      33      33              
Flag Coverage Δ
unittests 4.48% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugin/driver/ipvlan.go 0.00% <0.00%> (ø)
plugin/driver/netlink.go 0.00% <0.00%> (ø)
plugin/driver/raw_nic.go 0.00% <ø> (ø)
plugin/driver/utils.go 1.85% <0.00%> (-0.28%) ⬇️
plugin/driver/veth.go 0.00% <0.00%> (ø)
plugin/terway/cni.go 0.18% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bd1304...d506c01. Read the comment docs.

plugin/terway/cni.go Show resolved Hide resolved
plugin/terway/cni.go Show resolved Hide resolved
plugin/terway/cni.go Show resolved Hide resolved
plugin/driver/utils.go Show resolved Hide resolved
@l1b0k l1b0k requested a review from BSWANG December 20, 2021 03:54
@BSWANG BSWANG merged commit ff82a36 into AliyunContainerService:main Dec 20, 2021
@l1b0k l1b0k deleted the fix/teardown branch December 29, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants