Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize UnAssignIPForENI reduce unnecessary request #145

Merged
merged 1 commit into from
Nov 20, 2020
Merged

optimize UnAssignIPForENI reduce unnecessary request #145

merged 1 commit into from
Nov 20, 2020

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Nov 17, 2020

reduce unnecessary request

@l1b0k l1b0k changed the title change UnAssignIPForENI func to idempotent optimize UnAssignIPForENI reduce unnecessary request Nov 18, 2020
@codecov-io
Copy link

Codecov Report

Merging #145 (cc47d2e) into master (70111e2) will increase coverage by 0.15%.
The diff coverage is 45.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #145      +/-   ##
=========================================
+ Coverage    6.43%   6.59%   +0.15%     
=========================================
  Files          39      40       +1     
  Lines        5312    5320       +8     
=========================================
+ Hits          342     351       +9     
+ Misses       4949    4948       -1     
  Partials       21      21              
Impacted Files Coverage Δ
daemon/eni-multi-ip.go 0.00% <0.00%> (ø)
pkg/aliyun/ecs.go 0.00% <0.00%> (ø)
pkg/aliyun/utils.go 35.71% <62.50%> (+35.71%) ⬆️
pkg/aliyun/errors.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70111e2...cc47d2e. Read the comment docs.

@BSWANG BSWANG merged commit f7d14fe into AliyunContainerService:master Nov 20, 2020
@l1b0k l1b0k deleted the refactor-idempotent branch November 24, 2020 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants