Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

features: metrics & terway tracing cli #106

Merged
merged 8 commits into from
Jun 17, 2020
Merged

features: metrics & terway tracing cli #106

merged 8 commits into from
Jun 17, 2020

Conversation

Lyt99
Copy link
Contributor

@Lyt99 Lyt99 commented Jun 16, 2020

No description provided.

@Lyt99 Lyt99 force-pushed the features/tracing branch from 638ce8b to cb9bad8 Compare June 16, 2020 03:23
@Lyt99
add testing for GetResourceMapping
ec82dcc 
fix recursive & string literal
@Lyt99 Lyt99 force-pushed the features/tracing branch from cb9bad8 to ec82dcc Compare June 16, 2020 03:33
@Lyt99 Lyt99 force-pushed the features/tracing branch from 4262458 to ff6e1a3 Compare June 16, 2020 06:29
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2020 •
edited
Loading

Codecov Report

Merging #106 into master will increase coverage by 1.06%.
The diff coverage is 10.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #106      +/-   ##
=========================================
+ Coverage    6.19%   7.25%   +1.06%     
=========================================
  Files          31      36       +5     
  Lines        4423    5552    +1129     
=========================================
+ Hits          274     403     +129     
- Misses       4132    5126     +994     
- Partials       17      23       +6
Impacted Files Coverage Δ
daemon/daemon.go 0.00% <0.00%> (ø)
daemon/eni-multi-ip.go 0.00% <0.00%> (ø)
daemon/eni.go 6.39% <0.00%> (-2.07%) ⬇️
daemon/resource_manager.go 0.00% <ø> (ø)
daemon/server.go 0.00% <0.00%> (ø)
daemon/veth.go 0.00% <0.00%> (ø)
pkg/metric/util.go 0.00% <0.00%> (ø)
pkg/storage/store.go 0.00% <ø> (ø)
pkg/tracing/rpc.go 0.00% <0.00%> (ø)
cli/main.go 4.37% <4.37%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 830f904...a1cc241. Read the comment docs.

BSWANG
BSWANG requested changes Jun 16, 2020
View reviewed changes
cli/main.go Show resolved Hide resolved
cli/main.go Show resolved Hide resolved
daemon/eni-multi-ip.go Outdated Show resolved Hide resolved
cli/main.go Outdated Show resolved Hide resolved
cli/main.go Outdated Show resolved Hide resolved
daemon/daemon.go Outdated Show resolved Hide resolved
cli/main.go Outdated Show resolved Hide resolved
pkg/metric/aliyun.go Outdated Show resolved Hide resolved
pkg/metric/rpc.go Show resolved Hide resolved
rpc/tracing.proto Show resolved Hide resolved
@Lyt99
changes: metrics for latency change from summary to histogram & remov…
2e790ba 
…e config & trace command from cli

add document
@Lyt99 Lyt99 force-pushed the features/tracing branch 2 times, most recently from b6828a2 to 4478a06 Compare June 17, 2020 04:49
@Lyt99 Lyt99 force-pushed the features/tracing branch from 4478a06 to a1cc241 Compare June 17, 2020 04:53
@BSWANG BSWANG self-requested a review June 17, 2020 05:39
@BSWANG BSWANG merged commit 08ef0f4 into AliyunContainerService:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BSWANG BSWANG BSWANG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lyt99 @codecov-commenter @BSWANG