Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: modify onedrive upload chunk size #1831

Merged
merged 1 commit into from
Sep 27, 2022
Merged

perf: modify onedrive upload chunk size #1831

merged 1 commit into from
Sep 27, 2022

Conversation

hdm9527
Copy link
Contributor

@hdm9527 hdm9527 commented Sep 27, 2022

improve onedrive upload speed

improve onedrive upload speed
@welcome
Copy link

welcome bot commented Sep 27, 2022

Thanks for opening this pull request! Please check out our contributing guidelines.

@xhofe
Copy link
Collaborator

xhofe commented Sep 27, 2022

A byte range size of 10 MiB for stable high speed connections is optimal. For slower or less reliable connections you may get better results from a smaller fragment size. The recommended fragment size is between 5-10 MiB.

This may not be a good practice refer to docs of Onedrive API.

@hdm9527
Copy link
Contributor Author

hdm9527 commented Sep 27, 2022

cloudreve/Cloudreve#331 cloudreve/frontend@63ee122
refer to cloudreve

@xhofe
Copy link
Collaborator

xhofe commented Sep 27, 2022

Cloudreve doing this doesn't mean it's right to do so, but I can merge this pr first to see the effect later.

@hdm9527
Copy link
Contributor Author

hdm9527 commented Sep 27, 2022

ok

@xhofe xhofe merged commit 4e13b1a into AlistGo:main Sep 27, 2022
@welcome
Copy link

welcome bot commented Sep 27, 2022

Congrats on merging your first pull request! We here at behavior bot are proud of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants