Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): Allow loading extra config from file #340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dasJ
Copy link
Contributor

@dasJ dasJ commented Jan 11, 2023

No description provided.

@@ -163,6 +165,12 @@ + (void) prepareUserDefaults
for (count = 0; count < sizeof(confFiles)/sizeof(confFiles[0]); count++)
_injectConfigurationFromFile (configFromFiles, confFiles[count], logger);

/* Fill/Override configuration with configuration stored in the extra
* config file */
envFile = [[[NSProcessInfo processInfo] environment] objectForKey:@"SOGO_EXTRA_CONFIG_FILE"];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful if this was documented

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree. Do you have any pointer where an appropriate location would be?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WoodySlum
Copy link
Member

Hi @dasJ thanks for contributing ! Can you update documentation ?

Copy link
Member

@WoodySlum WoodySlum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add missing doc

@WoodySlum WoodySlum self-assigned this Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants