Better heuristic function that improves runtime on difficult levels #5
Conversation
taufeeque9
changed the title
| @@ -33,11 +33,14 @@ void RunAStar(const std::string& level_file_name, | |||
| std::ifstream log_file_in(log_file_name); | |||
| // check if the file is empty | |||
| if (log_file_in.peek() == std::ifstream::traits_type::eof()) { | |||
| log_file_out << "Level, Actions, Steps, SearchSteps" << std::endl; | |||
| log_file_out << "Level,Actions,Steps,SearchSteps" << std::endl; | |||
| } else { // skip levels that have already been run | |||
| std::string line; | |||
| std::getline(log_file_in, line); // skip header | |||
| while (std::getline(log_file_in, line)) { | |||
There was a problem hiding this comment.
It should be the case that line number = level number, but are we sure? Especially if sevearal concurrent workers are run. Maybe you should assert that?
There was a problem hiding this comment.
this file is only used to sequentially get the logs for the levels in a single file. So there shouldn't be any concurrent workers working on the same file.
There was a problem hiding this comment.
Sounds like this file has been replaced by astar_log_level.cc, is that true?
There was a problem hiding this comment.
Not really. astar_log_level.cc is to get the logs of a single level in a file, whereas astar_log.cc is to get the logs of all the levels in a file.
I think both are useful because if there are many different levels in many different files, then running astar_log.cc would be better. However, if we want to parallelize levels in a small number of files, then parallelizing across the levels with astar_log_level.cc should be better.
astar_log_level.ccto solve a particular level in a file. This should be used when logging levels across a small number of files.astar_log.ccshould still be used to log levels across a large number of files.