-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Algoworld build #30
Algoworld build #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments + fix all eslint errors before we proceed with next review round. For next round make sure to add some component and unit tests (refer to samples from other tests already on the repo)
One extra thing, can you hide the switched on build page if user is not logged in and in that state by default just have a centered text label saying authenticate to proceed with building or something like that |
e9ab244
to
114d7be
Compare
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 25.39% 25.88% +0.48%
==========================================
Files 85 95 +10
Lines 1331 1619 +288
Branches 109 130 +21
==========================================
+ Hits 338 419 +81
- Misses 989 1194 +205
- Partials 4 6 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
696477f
to
f19b90c
Compare
@MattAlgoworld i force pushed removing non commitlint compliant commit messages. Otherwise looks good! Will check the workers repo later and we can merge |
f19b90c
to
9de4087
Compare
ca19063
to
691142a
Compare
Draft PR for AlgoWorld build feature addition