Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algoworld build #30

Merged
merged 2 commits into from
May 13, 2023
Merged

Algoworld build #30

merged 2 commits into from
May 13, 2023

Conversation

MattAlgoworld
Copy link
Contributor

Draft PR for AlgoWorld build feature addition

Copy link
Collaborator

@aorumbayev aorumbayev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments + fix all eslint errors before we proceed with next review round. For next round make sure to add some component and unit tests (refer to samples from other tests already on the repo)

public/1.png Outdated Show resolved Hide resolved
src/components/Dialogs/BuildDialog.tsx Outdated Show resolved Hide resolved
src/components/Headers/NavBar.tsx Outdated Show resolved Hide resolved
src/components/ImageList/MapList.tsx Outdated Show resolved Hide resolved
src/components/ImageList/MapList.tsx Outdated Show resolved Hide resolved
src/redux/slices/applicationSlice.ts Outdated Show resolved Hide resolved
src/redux/slices/applicationSlice.ts Outdated Show resolved Hide resolved
@aorumbayev
Copy link
Collaborator

One extra thing, can you hide the switched on build page if user is not logged in and in that state by default just have a centered text label saying authenticate to proceed with building or something like that

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #30 (691142a) into main (f577377) will increase coverage by 0.48%.
The diff coverage is 28.37%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   25.39%   25.88%   +0.48%     
==========================================
  Files          85       95      +10     
  Lines        1331     1619     +288     
  Branches      109      130      +21     
==========================================
+ Hits          338      419      +81     
- Misses        989     1194     +205     
- Partials        4        6       +2     
Impacted Files Coverage Δ
src/components/ImageList/MapList.tsx 0.00% <0.00%> (ø)
src/components/Layouts/Layout.tsx 0.00% <ø> (ø)
src/components/Tables/BuildTransactionsTable.tsx 0.00% <0.00%> (ø)
src/models/AlgoWorldTransactionType.ts 0.00% <ø> (ø)
src/pages/build.page.tsx 0.00% <0.00%> (ø)
src/pages/leaderboard.page.tsx 0.00% <ø> (ø)
src/pages/my-transactions.page.tsx 0.00% <0.00%> (ø)
src/utils/transactions/createBuildNote.ts 0.00% <0.00%> (ø)
src/utils/transactions/createBuildTxns.ts 0.00% <0.00%> (ø)
src/redux/slices/applicationSlice.ts 39.79% <33.33%> (-2.86%) ⬇️
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aorumbayev
Copy link
Collaborator

@MattAlgoworld i force pushed removing non commitlint compliant commit messages. Otherwise looks good! Will check the workers repo later and we can merge

@aorumbayev aorumbayev marked this pull request as ready for review May 13, 2023 18:47
@aorumbayev aorumbayev merged commit a185ff1 into main May 13, 2023
@aorumbayev aorumbayev deleted the algoworld-build branch May 13, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants