-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli refactor #8
Cli refactor #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cusma LGTM! Nice restructuring, looks a lot cleaner now!
One quick thing though, maybe lets start versioning this and creating release tags. Since this is a minor upgrade - could you bump the version in pyproject file to 0.3.0? After that just ping me again and i'll approve - you can then create a v0.3.0 tagged release (or move it to algorealm org first and i can setup the release tag manually)
Sure! I was planning to do it in a PR from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh i see i didnt notice you used dev/main branches in this case. I think if we'll setup proper unit testing pipeline for this we won't need develop branch anymore, anyone can have feature branches and all testing will be solidified within pr pipelines. But we can refine it later, just a suggestion for now
Description
Since the project has now major external contributors I though it was time to clean up the messy code of the initial quick&dirty CLI project.
These are the main changes:
algorealm.py
(the actual CLI),actions.py
(game actions),query.py
(blockchain data query),consts.py
(useful constants);[--test]
option to the CLI to play on TestNet;getpass
to avoid typingmnemonic
in plain text;claim-majesty
command with mutually exclusive options (--crown
or--sceptre
);README.md
;Things that I would like to address in different future PRs:
[--test]
option for the AlgoRealm Special Card game;test
folder with proper tests.Checklist