Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring proposal, CI integration, linters integrations, renovate integration, sexy header logo (#1) #7

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

aorumbayev
Copy link
Collaborator

Description

Please explain the changes you made here

  • Switching to algonode from purestake (makes stuff easier for lay users)
  • Adding pre-commit with set of linters (isort, black and etc)
  • Adding ci pipeline
  • Adding pr templates
  • Adding new header logo
  • Refining readme
  • Restructuring the repo as prereq to turn it into a pypi package

Notes for @cusma:

Hey man, so Telegram notifications and etc wont work out in CLI mode cause each user will be forced to optain api keys 
themselves and we obviously don't want to hard code them. So this PR will just be a minor refactoring setting stage 
for later turning this into pypi package which i can use in future for frontend (which ill host in separate repo for now)

Checklist

Please, make sure to comply with the checklist below before expecting review

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

aorumbayev and others added 2 commits November 30, 2022 12:55
* Tweaking repo structure

* Adding renovate

* Tweaking python versioin
Copy link
Collaborator

@cusma cusma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

One minor improvement we could consider for the CLI is relying directly on a local KMD instead requiring a mnemonic. Another option could be using an input managed by getpass (like I did here for AlgoDices).

Thanks @aorumbayev

@cusma cusma merged commit e4bb40e into AlgoRealm:main Dec 1, 2022
@aorumbayev
Copy link
Collaborator Author

Looks good!

One minor improvement we could consider for the CLI is relying directly on a local KMD instead requiring a mnemonic. Another option could be using an input managed by getpass (like I did here for AlgoDices).

Thanks @aorumbayev

Yeah makes sense, I'll check out how you did it algodices and maybe have another minor PR.

Also make sure to authenticate this GitHub app to activate renovate config that I added in this PR - https://github.com/marketplace/renovate. Or you can add me as contributor to the repo so I can do so myself - will also be more convenient for me cause I could make branches on your repo instead of dealing with forking each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants