Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Longevity and Braveness #19

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Longevity and Braveness #19

merged 2 commits into from
Jan 3, 2023

Conversation

cusma
Copy link
Collaborator

@cusma cusma commented Jan 2, 2023

Description

This PR adds two new actions to the CLI:

  • longevity lists Majesties (either with --crown or --sceptre) sorted by reigns' longevity;
  • braveness lists Majesties (either with --crown or --sceptre) sorted by a new braveness ranking (based on donation relative growth rate).

Additional minor refactoring of query.

Checklist

Please, make sure to comply with the checklist below before expecting review

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@cusma cusma merged commit 3fba7df into main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants