Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Feat/extract http client from alfresco api client #1412

Merged

Conversation

mserwicki
Copy link
Contributor

@mserwicki mserwicki commented Aug 24, 2022

Please check if the PR fulfills these requirements

[x] The commit message follows our [guidelines](https://github.com/Alfresco/alfresco-js-api/wiki/Commit-format)
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

Currently we are not able to provide custom implementation for http client, and all calls are made with superagent

What is the new behavior?

We are able to create AlfrescoApi instance with custom http client.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@pr-triage pr-triage bot added the PR: draft label Aug 24, 2022
@mserwicki mserwicki force-pushed the feat/extract-http-client-from-alfresco-api-client branch from 2800226 to 7bd1ed1 Compare August 24, 2022 08:10
@mserwicki mserwicki marked this pull request as ready for review August 30, 2022 08:16
@mserwicki mserwicki force-pushed the feat/extract-http-client-from-alfresco-api-client branch from 7bd1ed1 to 545117f Compare August 30, 2022 08:19
Copy link
Contributor

@popovicsandras popovicsandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems good, but I guess this file needs some alignment as well:
api-codegen/src/main/resources/api-code-gen/base.api.mustache

Copy link
Contributor

@popovicsandras popovicsandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But please do not merge it yet, only after the release

@mserwicki mserwicki force-pushed the feat/extract-http-client-from-alfresco-api-client branch from e645b3b to 7b6f70a Compare September 8, 2022 19:59
@mserwicki mserwicki merged commit 2103ded into develop Sep 20, 2022
@mserwicki mserwicki deleted the feat/extract-http-client-from-alfresco-api-client branch September 20, 2022 11:27
@pr-triage pr-triage bot added the PR: merged label Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants