Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

[MNT-22840] Use ticket parameter instead of alf_ticket when withCredentials configuration is enabled #1392

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

tiagosalvado10
Copy link
Contributor

Please check if the PR fulfills these requirements

[x] The commit message follows our [guidelines](https://github.com/Alfresco/alfresco-js-api/wiki/Commit-format)
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

There are operations (as preview or download a document), where the URL sends the alf_ticket parameter. When Kerberos is enabled and ADW is accessed without SSO, these operations fail as the alf_ticket parameter doesn't work.

What is the new behavior?

If auth.withCredentials config is enabled, the ticket parameter is now sent instead of alf_ticket. The operations as preview or download a document now work.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@CLAassistant
Copy link

CLAassistant commented Jun 14, 2022

CLA assistant check
All committers have signed the CLA.

@eromano eromano merged commit a7fc2e9 into develop Jun 14, 2022
@eromano eromano deleted the MNT-22840-withCredentials-ticket-param branch June 14, 2022 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants