Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Being able to trigger the adf trigger from workflow #1379

Merged
merged 1 commit into from
May 9, 2022

Conversation

mauriziovitale
Copy link
Contributor

Please check if the PR fulfills these requirements

[ ] The commit message follows our [guidelines](https://github.com/Alfresco/alfresco-js-api/wiki/Commit-format)
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@mauriziovitale mauriziovitale merged commit 75ba257 into develop May 9, 2022
@mauriziovitale mauriziovitale deleted the manually-runflow branch May 9, 2022 14:53
@@ -111,7 +114,8 @@ jobs:

- name: Trigger ADF alpha
shell: bash
if: github.event.schedule == '0 3 * * *'
if: github.event.schedule == '0 3 * * *' || github.event_name == 'workflow_dispatch'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if: github.event.schedule == '0 3 * * *' || github.event_name == 'workflow_dispatch'
if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch'

should be more reliable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants