Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

ESLint support #1119

Merged
merged 3 commits into from
May 28, 2021
Merged

ESLint support #1119

merged 3 commits into from
May 28, 2021

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented May 28, 2021

Please check if the PR fulfills these requirements

[x] The commit message follows our [guidelines](https://github.com/Alfresco/alfresco-js-api/wiki/Commit-format)
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

the npm run lint command it going to produce a lot of warnings:

5732 problems (0 errors, 5732 warnings)

that is intentional and we should address clean code in future updates, the following rules will need to be removed and code fixed:

        'prefer-const': 1,
        'no-useless-escape': 1,
        'prefer-rest-params': 1,
        'prefer-spread': 1,
        'no-prototype-builtins': 1,
        '@typescript-eslint/explicit-module-boundary-types': 1,
        '@typescript-eslint/ban-ts-comment': 1,
        '@typescript-eslint/ban-types': 1,
        '@typescript-eslint/no-var-requires': 1,
        '@typescript-eslint/no-explicit-any': 1,
        '@typescript-eslint/no-empty-function': 1,
        '@typescript-eslint/no-namespace': 1,
        '@typescript-eslint/no-inferrable-types': 1,
        '@typescript-eslint/no-unused-vars': 1

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@mergify mergify bot merged commit c48f6bb into develop May 28, 2021
@mergify mergify bot deleted the eslint-support branch May 28, 2021 10:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants