This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
[aca-4419] add new event once user is logged in #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrn
approved these changes
May 11, 2021
| @@ -78,6 +90,10 @@ export class AlfrescoApi implements Emitter { | |||
| this.oauth2Auth.setConfig(this.config, this); | |||
| } | |||
|
|
|||
| this.oauth2Auth?.on('logged-in', () => { | |||
There was a problem hiding this comment.
By this time, can't we be sure, that we have this.oauth2Auth?
| @@ -87,16 +103,23 @@ export class AlfrescoApi implements Emitter { | |||
| this.processAuth.setConfig(this.config); | |||
| } | |||
|
|
|||
| this.processAuth?.on('logged-in', () => { | |||
There was a problem hiding this comment.
By this time, can't we be sure, that we have this.processAuth?
| if (!this.contentAuth) { | ||
| this.contentAuth = new ContentAuth(this.config, this); | ||
| } else { | ||
| this.contentAuth.setConfig(config); | ||
| } | ||
|
|
||
| this.contentAuth?.on('logged-in', () => { |
There was a problem hiding this comment.
By this time, can't we be sure, that we have this.contentAuth?
|
|
||
| reply(event: string, callback ?: any): void { | ||
| if (this.bufferEvents.indexOf(event) >= 0) { | ||
| Function.prototype.apply.call(callback, this, arguments); |
There was a problem hiding this comment.
callback?.apply(this, arguments)?
There was a problem hiding this comment.
What is this reply method for?
| @@ -141,7 +141,7 @@ export class AlfrescoApiCompatibility extends AlfrescoApi { | |||
| moduleCopy[currentClass] = module[currentClass]; | |||
| let obj = this._stringToObject(currentClass, module); | |||
| let nameObj = this._lowerFirst(currentClass); | |||
| obj.init(this); | |||
| obj?.init(this); | |||
There was a problem hiding this comment.
Why do we need this, if 2 lines above, we explicitly assigned a value to this variable? Is the returned interface of _stringToObject amboguous?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
add new event once user is logged in
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: