Skip to content
This repository has been archived by the owner on Dec 26, 2019. It is now read-only.

jQuery selector, explicit path required #4

Closed
peppertom opened this issue Aug 17, 2017 · 1 comment
Closed

jQuery selector, explicit path required #4

peppertom opened this issue Aug 17, 2017 · 1 comment

Comments

@peppertom
Copy link

Hello @AlfonsoFilho,

Calling ClipPath on a jQuery object needs an explicit declaration of the path, e.g. in the example it's correct, but in the readme it's a bit misleading:

$('.image').ClipPath({path:'5% 5%, 100% 0%, 100% 75%, 75% 75%, 75% 100%'});

instead of

$('.target').ClipPath('5% 5%, 100% 0%, 100% 75%');

Thanks.

AlfonsoFilho added a commit that referenced this issue Aug 19, 2017
- jQuery.ClipPath only argument is the path string
- backward compatibility with Object ensured
- devDependencies updated
- documentation updated
@AlfonsoFilho
Copy link
Owner

Apologies for that. In addition, instead of simply correcting the readme, I changed the ClipPath contract on jQuery implementation. So you should use a string. But this is not a breaking change. Use of object with path property still supported but deprecated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants