Register remaining late passes as late module passes

Alexendoo · Nov 9, 2023 · 0308fe7 · 0308fe7
1 parent 6ba6689
commit 0308fe7
Show file tree

Hide file tree

Showing 19 changed files with 685 additions and 668 deletions.
diff --git a/clippy_lints/src/lib.rs b/clippy_lints/src/lib.rs
diff --git a/tests/ui-toml/suppress_lint_in_const/test.stderr b/tests/ui-toml/suppress_lint_in_const/test.stderr
@@ -1,3 +1,9 @@
+error[E0080]: evaluation of constant value failed
+  --> $DIR/test.rs:15:24
+   |
+LL | const REF_ERR: &i32 = &ARR[idx4()]; // Ok, let rustc handle const contexts.
+   |                        ^^^^^^^^^^^ index out of bounds: the length is 2 but the index is 4
+
 error[E0080]: evaluation of `main::{constant#3}` failed
   --> $DIR/test.rs:37:14
    |
@@ -60,12 +66,6 @@ LL |     v[M];
    |
    = help: consider using `.get(n)` or `.get_mut(n)` instead
 
-error[E0080]: evaluation of constant value failed
-  --> $DIR/test.rs:15:24
-   |
-LL | const REF_ERR: &i32 = &ARR[idx4()]; // Ok, let rustc handle const contexts.
-   |                        ^^^^^^^^^^^ index out of bounds: the length is 2 but the index is 4
-
 error: aborting due to 8 previous errors
 
 For more information about this error, try `rustc --explain E0080`.
diff --git a/tests/ui-toml/undocumented_unsafe_blocks/undocumented_unsafe_blocks.default.stderr b/tests/ui-toml/undocumented_unsafe_blocks/undocumented_unsafe_blocks.default.stderr
@@ -148,6 +148,58 @@ LL |     println!("{}", unsafe { String::from_utf8_unchecked(vec![]) });
    |
    = help: consider adding a safety comment on the preceding line
 
+error: unsafe impl missing a safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:483:5
+   |
+LL |     unsafe impl ImplInFn for () {}
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = help: consider adding a safety comment on the preceding line
+
+error: unsafe impl missing a safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:492:1
+   |
+LL | unsafe impl CrateRoot for () {}
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = help: consider adding a safety comment on the preceding line
+
+error: statement has unnecessary safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:505:5
+   |
+LL | /     let _ = {
+LL | |         if unsafe { true } {
+LL | |             todo!();
+LL | |         } else {
+...  |
+LL | |         }
+LL | |     };
+   | |______^
+   |
+help: consider removing the safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:504:5
+   |
+LL |     // SAFETY: this is more than one level away, so it should warn
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   = note: `-D clippy::unnecessary-safety-comment` implied by `-D warnings`
+   = help: to override `-D warnings` add `#[allow(clippy::unnecessary_safety_comment)]`
+
+error: unsafe block missing a safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:506:12
+   |
+LL |         if unsafe { true } {
+   |            ^^^^^^^^^^^^^^^
+   |
+   = help: consider adding a safety comment on the preceding line
+
+error: unsafe block missing a safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:509:23
+   |
+LL |             let bar = unsafe {};
+   |                       ^^^^^^^^^
+   |
+   = help: consider adding a safety comment on the preceding line
+
 error: unsafe impl missing a safety comment
   --> $DIR/undocumented_unsafe_blocks.rs:350:5
    |
@@ -251,8 +303,6 @@ help: consider removing the safety comment
    |
 LL |     // SAFETY:
    |     ^^^^^^^^^^
-   = note: `-D clippy::unnecessary-safety-comment` implied by `-D warnings`
-   = help: to override `-D warnings` add `#[allow(clippy::unnecessary_safety_comment)]`
 
 error: unsafe impl missing a safety comment
   --> $DIR/undocumented_unsafe_blocks.rs:476:5
@@ -262,55 +312,5 @@ LL |     unsafe impl Interference for () {}
    |
    = help: consider adding a safety comment on the preceding line
 
-error: unsafe impl missing a safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:483:5
-   |
-LL |     unsafe impl ImplInFn for () {}
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |
-   = help: consider adding a safety comment on the preceding line
-
-error: unsafe impl missing a safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:492:1
-   |
-LL | unsafe impl CrateRoot for () {}
-   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |
-   = help: consider adding a safety comment on the preceding line
-
-error: statement has unnecessary safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:505:5
-   |
-LL | /     let _ = {
-LL | |         if unsafe { true } {
-LL | |             todo!();
-LL | |         } else {
-...  |
-LL | |         }
-LL | |     };
-   | |______^
-   |
-help: consider removing the safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:504:5
-   |
-LL |     // SAFETY: this is more than one level away, so it should warn
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: unsafe block missing a safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:506:12
-   |
-LL |         if unsafe { true } {
-   |            ^^^^^^^^^^^^^^^
-   |
-   = help: consider adding a safety comment on the preceding line
-
-error: unsafe block missing a safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:509:23
-   |
-LL |             let bar = unsafe {};
-   |                       ^^^^^^^^^
-   |
-   = help: consider adding a safety comment on the preceding line
-
 error: aborting due to 35 previous errors
 
diff --git a/tests/ui-toml/undocumented_unsafe_blocks/undocumented_unsafe_blocks.disabled.stderr b/tests/ui-toml/undocumented_unsafe_blocks/undocumented_unsafe_blocks.disabled.stderr
@@ -148,120 +148,6 @@ LL |     println!("{}", unsafe { String::from_utf8_unchecked(vec![]) });
    |
    = help: consider adding a safety comment on the preceding line
 
-error: unsafe impl missing a safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:350:5
-   |
-LL |     unsafe impl A for () {}
-   |     ^^^^^^^^^^^^^^^^^^^^^^^
-   |
-   = help: consider adding a safety comment on the preceding line
-
-error: unsafe impl missing a safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:357:9
-   |
-LL |         unsafe impl B for (u32) {}
-   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |
-   = help: consider adding a safety comment on the preceding line
-
-error: unsafe impl missing a safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:378:13
-   |
-LL |             unsafe impl T for $t {}
-   |             ^^^^^^^^^^^^^^^^^^^^^^^
-...
-LL |     no_safety_comment!(());
-   |     ---------------------- in this macro invocation
-   |
-   = help: consider adding a safety comment on the preceding line
-   = note: this error originates in the macro `no_safety_comment` (in Nightly builds, run with -Z macro-backtrace for more info)
-
-error: unsafe impl missing a safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:403:13
-   |
-LL |             unsafe impl T for $t {}
-   |             ^^^^^^^^^^^^^^^^^^^^^^^
-...
-LL |     no_safety_comment!(());
-   |     ---------------------- in this macro invocation
-   |
-   = help: consider adding a safety comment on the preceding line
-   = note: this error originates in the macro `no_safety_comment` (in Nightly builds, run with -Z macro-backtrace for more info)
-
-error: unsafe impl missing a safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:411:5
-   |
-LL |     unsafe impl T for (i32) {}
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |
-   = help: consider adding a safety comment on the preceding line
-
-error: unsafe impl missing a safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:403:13
-   |
-LL |             unsafe impl T for $t {}
-   |             ^^^^^^^^^^^^^^^^^^^^^^^
-...
-LL |     no_safety_comment!(u32);
-   |     ----------------------- in this macro invocation
-   |
-   = help: consider adding a safety comment on the preceding line
-   = note: this error originates in the macro `no_safety_comment` (in Nightly builds, run with -Z macro-backtrace for more info)
-
-error: unsafe impl missing a safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:417:5
-   |
-LL |     unsafe impl T for (bool) {}
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |
-   = help: consider adding a safety comment on the preceding line
-
-error: unsafe impl missing a safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:463:5
-   |
-LL |     unsafe impl NoComment for () {}
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |
-   = help: consider adding a safety comment on the preceding line
-
-error: unsafe impl missing a safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:467:19
-   |
-LL |     /* SAFETY: */ unsafe impl InlineComment for () {}
-   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |
-   = help: consider adding a safety comment on the preceding line
-
-error: unsafe impl missing a safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:471:5
-   |
-LL |     unsafe impl TrailingComment for () {} // SAFETY:
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |
-   = help: consider adding a safety comment on the preceding line
-
-error: constant item has unnecessary safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:475:5
-   |
-LL |     const BIG_NUMBER: i32 = 1000000;
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |
-help: consider removing the safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:474:5
-   |
-LL |     // SAFETY:
-   |     ^^^^^^^^^^
-   = note: `-D clippy::unnecessary-safety-comment` implied by `-D warnings`
-   = help: to override `-D warnings` add `#[allow(clippy::unnecessary_safety_comment)]`
-
-error: unsafe impl missing a safety comment
-  --> $DIR/undocumented_unsafe_blocks.rs:476:5
-   |
-LL |     unsafe impl Interference for () {}
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |
-   = help: consider adding a safety comment on the preceding line
-
 error: unsafe impl missing a safety comment
   --> $DIR/undocumented_unsafe_blocks.rs:483:5
    |
@@ -303,6 +189,8 @@ help: consider removing the safety comment
    |
 LL |     // SAFETY: this is more than one level away, so it should warn
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   = note: `-D clippy::unnecessary-safety-comment` implied by `-D warnings`
+   = help: to override `-D warnings` add `#[allow(clippy::unnecessary_safety_comment)]`
 
 error: unsafe block missing a safety comment
   --> $DIR/undocumented_unsafe_blocks.rs:506:12
@@ -392,5 +280,117 @@ LL |     unsafe {}
    |
    = help: consider adding a safety comment on the preceding line
 
+error: unsafe impl missing a safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:350:5
+   |
+LL |     unsafe impl A for () {}
+   |     ^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = help: consider adding a safety comment on the preceding line
+
+error: unsafe impl missing a safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:357:9
+   |
+LL |         unsafe impl B for (u32) {}
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = help: consider adding a safety comment on the preceding line
+
+error: unsafe impl missing a safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:378:13
+   |
+LL |             unsafe impl T for $t {}
+   |             ^^^^^^^^^^^^^^^^^^^^^^^
+...
+LL |     no_safety_comment!(());
+   |     ---------------------- in this macro invocation
+   |
+   = help: consider adding a safety comment on the preceding line
+   = note: this error originates in the macro `no_safety_comment` (in Nightly builds, run with -Z macro-backtrace for more info)
+
+error: unsafe impl missing a safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:403:13
+   |
+LL |             unsafe impl T for $t {}
+   |             ^^^^^^^^^^^^^^^^^^^^^^^
+...
+LL |     no_safety_comment!(());
+   |     ---------------------- in this macro invocation
+   |
+   = help: consider adding a safety comment on the preceding line
+   = note: this error originates in the macro `no_safety_comment` (in Nightly builds, run with -Z macro-backtrace for more info)
+
+error: unsafe impl missing a safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:411:5
+   |
+LL |     unsafe impl T for (i32) {}
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = help: consider adding a safety comment on the preceding line
+
+error: unsafe impl missing a safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:403:13
+   |
+LL |             unsafe impl T for $t {}
+   |             ^^^^^^^^^^^^^^^^^^^^^^^
+...
+LL |     no_safety_comment!(u32);
+   |     ----------------------- in this macro invocation
+   |
+   = help: consider adding a safety comment on the preceding line
+   = note: this error originates in the macro `no_safety_comment` (in Nightly builds, run with -Z macro-backtrace for more info)
+
+error: unsafe impl missing a safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:417:5
+   |
+LL |     unsafe impl T for (bool) {}
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = help: consider adding a safety comment on the preceding line
+
+error: unsafe impl missing a safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:463:5
+   |
+LL |     unsafe impl NoComment for () {}
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = help: consider adding a safety comment on the preceding line
+
+error: unsafe impl missing a safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:467:19
+   |
+LL |     /* SAFETY: */ unsafe impl InlineComment for () {}
+   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = help: consider adding a safety comment on the preceding line
+
+error: unsafe impl missing a safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:471:5
+   |
+LL |     unsafe impl TrailingComment for () {} // SAFETY:
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = help: consider adding a safety comment on the preceding line
+
+error: constant item has unnecessary safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:475:5
+   |
+LL |     const BIG_NUMBER: i32 = 1000000;
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+help: consider removing the safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:474:5
+   |
+LL |     // SAFETY:
+   |     ^^^^^^^^^^
+
+error: unsafe impl missing a safety comment
+  --> $DIR/undocumented_unsafe_blocks.rs:476:5
+   |
+LL |     unsafe impl Interference for () {}
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = help: consider adding a safety comment on the preceding line
+
 error: aborting due to 45 previous errors