Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add remaining tests for alias #5

Merged
merged 5 commits into from
Jun 16, 2024
Merged

feat: add remaining tests for alias #5

merged 5 commits into from
Jun 16, 2024

Conversation

AlessandroMiola
Copy link
Owner

Summary:

  • e45bbfc, b7396e0, 493c0fd: attempts to further investigate the not working behaviour when referencing just commands in .pre-commit-config.yaml. I'm still not able to correctly interpret the answer from https://stackoverflow.com/questions/78243419/just-error-justfile-does-not-contain-recipes-when-pre-committing, nor any other solution I've tried does work; revert to using "unrolled" poetry run commands in .pre-commit-config.yaml1
  • 3c2d72f:
    • tests/aliasing/conftest.py: add fixtures to deal with AliasGenerator and alias_priority configs
    • tests/aliasing/test_combination_aliases.py: test AliasGenerator and alias_priority combinations
  • 9ba22fb:
    • tests/aliasing/conftest.py: add fixtures to deal with AliasChoices and AliasPath
    • tests/aliasing/test_validation_alias.py: test validation with AliasChoices and AliasPath

Footnotes

  1. must not be an issue solely pertaining to just though, but rather to referencing just commands in .pre-commit-config.yaml. Indeed, the same commands do work smoothly in .github/workflows/actions.yaml

@AlessandroMiola AlessandroMiola merged commit 51aebd6 into main Jun 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant