Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path bug proposed fix #248

Closed
wants to merge 8 commits into from
Closed

Path bug proposed fix #248

wants to merge 8 commits into from

Conversation

escritorio-gustavo
Copy link
Contributor

No description provided.

@escritorio-gustavo escritorio-gustavo mentioned this pull request Mar 1, 2024
Merged
@escritorio-gustavo
Copy link
Contributor Author

@NyxCode, It seems like there is a difference between CARGO_MANIFEST_DIR and current_dir

CARGO_MANIFEST_DIR causes example to export into ts-rs/bindings

@escritorio-gustavo
Copy link
Contributor Author

escritorio-gustavo commented Mar 4, 2024 •
edited
Loading

After messing about with this a bit more, I figured out how to make #[ts(export_to = "...")] relative to TS_RS_EXPORT_DIR when they are both being used. Also managed to get rid of the __private module and TS::get_export_to function, going back to our ol'reliable TS::EXPORT_TO.

I will push these changes after we merge a solution to #247

@escritorio-gustavo escritorio-gustavo deleted the path-bug-proposed-fix branch March 4, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NyxCode NyxCode Awaiting requested review from NyxCode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@escritorio-gustavo