Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for rename_all on enum struct variants #197

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Add test for rename_all on enum struct variants #197

merged 3 commits into from
Jan 22, 2024

Conversation

escritorio-gustavo
Copy link
Contributor

Added test requested in this thread: #135 (comment)

Fixed version of #196

@escritorio-gustavo
Copy link
Contributor Author

I seem to be really bad at making these PRs the first one included wrong code and this seems to include nothing at all smh

@NyxCode
Copy link
Collaborator

NyxCode commented Jan 22, 2024

😄 All good, thanks for the PR!
I really like that we are accumulating loads of test. Really helps with making changes when there's confidence that we didnt break anything important.

@escritorio-gustavo
Copy link
Contributor Author

Yeah, I was kind of scared of making the #199 PR until I ran cargo test and nothing failed xD

@NyxCode NyxCode merged commit 3bac04d into Aleph-Alpha:main Jan 22, 2024
1 check passed
@NyxCode
Copy link
Collaborator

NyxCode commented Jan 22, 2024

At least I really have to rely on the test suite at this point. No way I can look at a piece of code and understand all of its implications.

@escritorio-gustavo escritorio-gustavo deleted the test_enum_struct_rename_all branch January 22, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants