Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lints from the updated nightly #1589

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

ljedrz
Copy link
Collaborator

@ljedrz ljedrz commented Jan 24, 2022

It seems that the nightly image was updated, causing the pending PRs to fail the clippy job. This PR takes care of the current clippy lints.

@ljedrz ljedrz added refactor Codebase refactor, optimization, or cleanup testnet2 labels Jan 24, 2022
@ljedrz
Copy link
Collaborator Author

ljedrz commented Jan 24, 2022

Oof, seems that my nightly was just 2 days shy of one new lint; checking it out now.

@ljedrz
Copy link
Collaborator Author

ljedrz commented Jan 24, 2022

I'm not 100% sure the new format_args vs. await error is legitimate, but I haven't found any related bug reports, and working around it is trivial and doesn't have downsides.

Copy link
Collaborator

@niklaslong niklaslong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ljedrz
Copy link
Collaborator Author

ljedrz commented Jan 25, 2022

This appears to be a bug after all: rust-lang/rust#93274. That being said, the workaround doesn't hurt.

@howardwu howardwu merged commit ba33a93 into AleoNet:testnet2 Jan 27, 2022
@ljedrz ljedrz deleted the testnet2_updated_nightly_clippies branch January 27, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Codebase refactor, optimization, or cleanup testnet2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants