Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple columns with same name error for JOIN USING #573

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Fix multiple columns with same name error for JOIN USING #573

merged 1 commit into from
Nov 5, 2023

Conversation

eygraber
Copy link
Contributor

@eygraber eygraber commented Nov 3, 2023 •
edited by hfhbd
Loading

Fixes cashapp/sqldelight#4767

Not sure if this is the correct approach here, but I couldn't think of any other way to do it with changing other behavior.

hfhbd
hfhbd approved these changes Nov 5, 2023
View reviewed changes
Copy link
Collaborator

@hfhbd hfhbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@hfhbd hfhbd merged commit 9f41ad0 into AlecKazakova:master Nov 5, 2023
1 check passed
@eygraber eygraber deleted the joins-with-using-error branch November 5, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfhbd hfhbd hfhbd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple joins with USING and the same column id clause compilation error
2 participants
@eygraber @hfhbd