Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Add option to show/hide cursor when prompting user (#345) #348

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

dmartin35
Copy link
Contributor

No description provided.

@AlecAivazis
Copy link
Owner

Thanks for adding this option! I noticed you kept the default behavior the same which I appreciate. I'll take a look at why the github action is failing but once that goes through i suspect we can get this in

@dmartin35
Copy link
Contributor Author

it seems the test workflow is broken when doing the install runner step (go get -v github.com/alecaivazis/run), due to the following error:
Error: ../../../go/src/github.com/alecaivazis/run/config.go:119:9: undefined: hcl.Unmarshal

@AlecAivazis
Copy link
Owner

@dmartin35 - i fixed the issue preventing the CI pipeline from executing. Mind rebasing onto master so we can get this in?

@dmartin35 dmartin35 force-pushed the show-cursor-option branch from 5f83e92 to 726e7cb Compare April 22, 2021 14:21
@dmartin35
Copy link
Contributor Author

Yes, I did the rebase, I thinks that's good now. Let me know if you need more. Thanks

@AlecAivazis
Copy link
Owner

Perfect, thanks!

@AlecAivazis AlecAivazis merged commit b70520c into AlecAivazis:master Apr 22, 2021
@dmartin35 dmartin35 deleted the show-cursor-option branch April 22, 2021 14:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants