Use CP1252 encoding for CAOS injection instead of UTF8#3
Open
bedalton wants to merge 2 commits intoAlbianWarp:masterfrom
Open
Use CP1252 encoding for CAOS injection instead of UTF8#3bedalton wants to merge 2 commits intoAlbianWarp:masterfrom
bedalton wants to merge 2 commits intoAlbianWarp:masterfrom
Conversation
Creatures expects CAOS to be encoded in CP1252. Use of UTF8 cause encoding issues and garbled text.
Contributor
|
Static review of the code looks good to me :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creatures expects CAOS to be text encoded with CP1252 encoding. Use of UTF8 causes encoding issues and garbled text.
This pull request replaces UTF8 encoding/decoding with CP1252