fix(comment): resolve inaccurate comment checks preventing merge #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-qing
commented
Oct 24, 2025
| func (c *Client) addApprovedReviews(lgtmUsers map[string]string, userLatestReviews map[string]*git.Review) { | ||
| func (c *Client) addApprovedReviews(lgtmUsers map[string]string, userLatestReviews map[string]*git.Review, userApprovedReviews map[string]*git.Review) { | ||
| for user, latestReview := range userLatestReviews { | ||
| if latestReview.State == "APPROVED" { |
There was a problem hiding this comment.
之前就是这里的问题，kycheng 在第一个 APPROVED 后，有发送了一个 COMMENTED 消息，导致了误判。
chengjingtao
approved these changes
Oct 27, 2025
|
/lgtm |
|
ℹ️ Self-approval not allowed @l-qing, as the PR author, you cannot approve your own PR. However, I can show you the current LGTM status for this PR: ✅ LGTM Status - Ready to Merge This PR has received 1/1 valid LGTM approvals and meets the approval threshold. LGTM Summary:
The PR is now ready for merge! 🎉 ✅ Check Runs Status - All checks are passing This PR is ready for merge from a technical perspective! |
|
🎉 PR Successfully Merged! Merge details:
Approvers:
Thank you to all reviewers! 🙏 |
|
Multi-Command Execution Results: ✅ Command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist: