Simplify and refactor #2691
Simplify and refactor #2691
Conversation
| @@ -109,7 +109,7 @@ extension DataRequest { | |||
| /// - completionHandler: The code to be executed once the request has finished. | |||
| /// - Returns: The request. | |||
| @discardableResult | |||
| public func response(queue: DispatchQueue? = nil, completionHandler: @escaping (DataResponse<Data?>) -> Void) -> Self { | |||
| public func response(queue: DispatchQueue = .main, completionHandler: @escaping (DataResponse<Data?>) -> Void) -> Self { | |||
There was a problem hiding this comment.
If we're going to make this change, it would be good to audit all API that takes optional values with a coalesced value in the body, and change them all to work like this.
There was a problem hiding this comment.
From what I saw, I couldn't find any similar case to this.
| } | ||
| } | ||
| } | ||
|
|
||
| // MARK: Properties | ||
|
|
||
| /// Returns a default `URLEncoding` instance. | ||
| /// Returns a default `URLEncoding` instance with a `.methodDependent` destination. |
There was a problem hiding this comment.
I'm not sure about this one. Perhaps keeping default and adding an httpBody convenience property?
There was a problem hiding this comment.
I am not understanding your comment. I need more context. What is the issue about?
|
Thank you for your response @jshier. I will try to address your comments as soon as possible. |
|
Thanks for putting this all together @jdisho. I'm going to take a stab at putting together a different PR with most of these changes while keeping your attribution. I'll link the new PR once it's up. |
|
Hi @jdisho, I just pushed up #2765 which pulls in these changes, culls out a few of them, and rebases on top of the #2716 PR. I made sure to maintain your attribution to the changeset. I'm going to go ahead and close out this PR for now. Please redirect all further comments to #2765. These changes will go out as part of AF5 beta 4. Cheers. 🍻 |
This is my first PR. First of all, I want to thank you for your time investment in
Alamofire. Amazing lib 👏Goals ⚽
Simplifying and refactoring some basic things.
Implementation Details 🚧
switchstatements. Theswitchcases which are simplified are 2 case statements and can we simplified by usingguard..mainrather thannil. I did this because under the hood,.mainis used when the queue value isnil.methodDependentproperty inParameterEncodingsince it is a duplication ofdefault. (If there is a reason whymethodDependentanddefaultare included, I would be interested to know why 😄)encodesParametersInURLinParameterEncodingby making it part ofDestination. (I occurred that in the same wayencodesParametersInURLis implemented inParameterEncoder)