Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestRetrier timeDelay not honored after encountering AdaptError #1853

Closed
ejensen opened this issue Dec 15, 2016 · 2 comments
Closed

RequestRetrier timeDelay not honored after encountering AdaptError #1853

ejensen opened this issue Dec 15, 2016 · 2 comments
Assignees
@cnoon
Labels
bug request retrier
Milestone
4.3.0

Comments

@ejensen
Copy link
Contributor

ejensen commented Dec 15, 2016

In SessionManager.allowRetrier() the timeDelay supplied by the request retrier is not honored.
This code path is hit when a request fails due to an AdaptError.
Alamofire v4.2.0
@cnoon cnoon self-assigned this Dec 16, 2016
@cnoon cnoon added this to the 4.3.0 milestone Dec 16, 2016
@cnoon
Copy link
Member

cnoon commented Dec 16, 2016

I've verified this is in fact a bug. Should be a simple fix.

cnoon added a commit that referenced this issue Dec 19, 2016
@cnoon
[Issue #1853] Fixed issue where SessionManager did not respect retry …
097787e 
…time delay.
@cnoon cnoon mentioned this issue Dec 19, 2016
Merged
@cnoon
Copy link
Member

cnoon commented Dec 19, 2016

I just put up PR #1864 to address this issue. I'm going to close this issue out. Please direct all future comments to #1864. Thanks @ejensen for filing! 🍻

@cnoon cnoon closed this as completed Dec 19, 2016
cnoon added a commit that referenced this issue Jan 14, 2017
@cnoon
[Issue #1853] Fixed issue where SessionManager did not respect retry …
25d8fdd 
…time delay.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cnoon cnoon

Labels
bug request retrier
Projects
None yet
Milestone
4.3.0
Development

No branches or pull requests
2 participants
@cnoon @ejensen