Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image deleted, but still in preview window after a new generation #3

Open
Aamir3d opened this issue Mar 13, 2023 · 4 comments
Open
Labels
bug Something isn't working enhancement New feature or request

Comments

@Aamir3d
Copy link

Aamir3d commented Mar 13, 2023

Two issues actually

  1. The image gets deleted, but if there's a new generation, the deleted image still stays in the preview window (Happens sometimes, not all the time)

  2. The prompt text doesn't change (the behavior should be that if an image is deleted, and a new image is generated, the "image deleted" text should go away.

  3. Image deleted text shows CORRECTLY after deleting a bad generation
    image

  4. After generating a new image, the text still shows
    image

@AlUlkesh AlUlkesh added bug Something isn't working enhancement New feature or request labels Mar 13, 2023
AlUlkesh added a commit that referenced this issue Mar 14, 2023
@AlUlkesh
Copy link
Owner

With this commit, the info field doesn't show the last message anymore, when a new generation is started.

The preview issue is much trickier. The problem is, that depending on what you change for a new generation, the new filename will be the same as the deleted filename. In this case apparently the browser uses its cache and shows the old image.

I have no idea yet, how this could be fixed...

@Aamir3d
Copy link
Author

Aamir3d commented Mar 14, 2023

With this commit, the info field doesn't show the last message anymore, when a new generation is started.

The preview issue is much trickier. The problem is, that depending on what you change for a new generation, the new filename will be the same as the deleted filename. In this case apparently the browser uses its cache and shows the old image.

I have no idea yet, how this could be fixed...

Interesting info, I'll make sure to be more careful.
Thank you for being so proactive!

@lrichert
Copy link

An easy temporary fix (client side) is changing the filename pattern:

Settings > Saving images/grids > Images filename pattern
[datetime<%Y%m%d_%H%M%S_%f>]-[seed] = 20240122_001744_666968-193762924.png
This includes microseconds to ensure 100% unique filenames, according to the Wiki (might be necessary with certain extensions only)

Also, thank you so, so much for this extension. It's a must-have for me!

@AlUlkesh
Copy link
Owner

@lrichert Great idea! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants