Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mont 64 #1

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Mont 64 #1

wants to merge 15 commits into from

Conversation

Al-Kindi-0
Copy link
Owner

First PR

@Al-Kindi-0 Al-Kindi-0 requested a review from bobbinth June 13, 2022 21:20
bobbinth
bobbinth requested changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good. I left a bunch of small comments inline.

math/Cargo.toml Outdated Show resolved Hide resolved
math/src/field/f64/mod.rs Outdated Show resolved Hide resolved
math/src/field/f64/mod.rs Outdated Show resolved Hide resolved
math/src/field/f64/mod.rs Outdated Show resolved Hide resolved
math/src/field/f64/mod.rs Outdated Show resolved Hide resolved
math/src/field/f64/mod.rs Show resolved Hide resolved
math/src/field/f64/mod.rs Outdated Show resolved Hide resolved
math/src/field/f64/mod.rs Outdated Show resolved Hide resolved
math/src/field/f64/mod.rs Outdated Show resolved Hide resolved
math/src/field/f64/mod.rs Outdated Show resolved Hide resolved
bobbinth
bobbinth requested changes Jun 14, 2022
View reviewed changes
Copy link
Collaborator

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a few more nits inline.

One other thing - let's move msquare() and equals() into helper function sections. Unless there is a need to expose them in the public interface.

math/Cargo.toml Outdated Show resolved Hide resolved
math/src/field/f64/mod.rs Outdated Show resolved Hide resolved
math/src/field/f64/mod.rs Outdated Show resolved Hide resolved
math/src/field/f64/mod.rs Outdated Show resolved Hide resolved
math/src/field/f64/mod.rs Outdated Show resolved Hide resolved
bobbinth
bobbinth requested changes Jun 14, 2022
View reviewed changes
Copy link
Collaborator

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I left a couple of minor nits inline.

I think the last thing left is to make sure serialization tests pass as well.

math/src/field/f64/mod.rs Outdated Show resolved Hide resolved
math/src/field/f64/mod.rs Outdated Show resolved Hide resolved
math/src/field/f64/mod.rs Outdated Show resolved Hide resolved
math/src/field/f64/mod.rs Outdated Show resolved Hide resolved
bobbinth
bobbinth requested changes Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a few small nits inline. Also, I think a comment on line 18 needs to be updated.

math/src/field/f64/tests.rs Outdated Show resolved Hide resolved
math/src/field/f64/tests.rs Outdated Show resolved Hide resolved
math/src/field/f64/tests.rs Outdated Show resolved Hide resolved
math/src/field/f64/tests.rs Outdated Show resolved Hide resolved
@Al-Kindi-0 Al-Kindi-0 force-pushed the main branch 2 times, most recently from 2496f01 to eea409c Compare November 2, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Al-Kindi-0 @bobbinth