Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] No Option to Set Consumption Size For Food/Drink Items #100

Closed
Manwe-fv opened this issue Feb 5, 2023 · 4 comments
Closed

[Bug] No Option to Set Consumption Size For Food/Drink Items #100

Manwe-fv opened this issue Feb 5, 2023 · 4 comments

Comments

@Manwe-fv
Copy link

Manwe-fv commented Feb 5, 2023

As far as I can tell, Spire does not have any field to adjust food or drink consumption values, which are housed in field casttime_. I'm assuming this would be found in the spells section.

image

If you set casttime_ to any value in the DB directly, then save the item in spire, reverts it back to 0. That obviously makes it impossible to adjust food stats, etc., without having to go back into the DB after the fact.

Here are the associated values: https://docs.eqemu.io/server/items/food-and-drink/

It would also be helpful if the item preview displayed the meal/drink message: "This is a miraculous meal!", etc.

@Manwe-fv Manwe-fv changed the title No Option to Set Consumption Size For Food/Drink Items [Bug] No Option to Set Consumption Size For Food/Drink Items Feb 8, 2023
@jcr4990
Copy link

jcr4990 commented Feb 11, 2023

I came here to post about this exact thing. Glad I checked before DMing or making another issue. I ended up having to make a thread in discord to ask how to set those values cause it wasn't super obvious and the docs (as far as I could tell) were missing the reference to the casttime_ field. I put in a PR to update that docs page to include it. Once I figured out what field it was I went through each tab of spire to double check and make sure I didn't miss it and it doesn't seem to be there. I can also confirm the casttime_ field is reset to 0 anytime the item is edited in Spire.

@Akkadius
Copy link
Owner

I'll fix it in the coming weeks during the bug bash

@Akkadius
Copy link
Owner

Akkadius commented Apr 3, 2023

This will be fixed in 3.0.0

A new tab of "Food" will be added along with preview rendering

image

  static getFoodDescription(item: Object) {
    // @ts-ignore
    const v            = item.casttime_;
    const descriptions = [
      {t: 14, l: 0, h: 5, desc: "This is a snack."},
      {t: 14, l: 6, h: 20, desc: "This is a meal."},
      {t: 14, l: 21, h: 30, desc: "This is a hearty meal."},
      {t: 14, l: 31, h: 40, desc: "This is a banquet size meal."},
      {t: 14, l: 41, h: 50, desc: "This meal is a feast!"},
      {t: 14, l: 51, h: 60, desc: "This is an enduring meal!"},
      {t: 14, l: 61, h: 10000, desc: "This is a miraculous meal!"},
      {t: 15, l: 0, h: 5, desc: "This is a whistle wetter."},
      {t: 15, l: 6, h: 20, desc: "This is a drink."},
      {t: 15, l: 21, h: 30, desc: "This is a refreshing drink."},
      {t: 15, l: 31, h: 40, desc: "This is a lasting drink."},
      {t: 15, l: 41, h: 50, desc: "This meal is a flowing drink!"},
      {t: 15, l: 51, h: 60, desc: "This is an enduring drink!"},
      {t: 15, l: 61, h: 10000, desc: "This is a miraculous drink!"},
    ]

    for (let d of descriptions) {
      // @ts-ignore
      if (d.t === item.itemtype && v >= d.l && v <= d.h) {
        return d.desc
      }
    }

    return "";
  }

@Akkadius Akkadius closed this as completed Apr 3, 2023
Akkadius added a commit that referenced this issue Apr 3, 2023
@Akkadius
Copy link
Owner

Akkadius commented Apr 3, 2023

Also. The original item editor was to have "Simple views" for incredibly simple item types where you don't need to see an overwhelming amount of inputs, fields etc.

This would be great for things like tradeskill items, keys, bags, food etc.

This is still on my radar at some point

Akkadius added a commit that referenced this issue Apr 3, 2023
* Test

* Update Connections.vue

* Update Navbar.vue

* Add escape button back into quest api explorer

* Update Navbar.vue

* Fix Github login

* Suck less

* Break page and hotkeys

* Spire initialization work

* More init work

* More init work

* Finish user login

* Fix issues with connection page

* Tweaks to auth

* Auto inject local database instance into db connection

* Fix database connection update info logic

* Connection management work / cleanup

* Local user management

* Navbar admin fixes

* Password reset

* Change permissions response code to 403 instead of 401, be more descriptive about permission error return

* Implement Occulus proxy logic

* Get first Occulus page ported over

* More occulus work

* UI tweaks

* Port players online page

* UI tweaks

* Zone Servers

* Ported netstat page

* Port configuration

* Port tools

* Port client asset public downloading

* Tweaks

* Misc tweaks

* Implement process management

* Move configuration nav

* Consolidate navs

* Cleanup UI

* Update ServerProcessButtonComponent.vue

* Server rules cleanup, deep link rule searching

* Tweak and cleanup server rules page and zoneservers page

* Cleaning up components

* Tweaks

* Occulus require info route

* Only run Occulus integration locally

* AppEnv route checks

* Update PlayersOnlineComponent.vue

* Tweaks

* Generate player event model

* Generate API pipeline

* Update wire_gen.go

* Gen PlayerEventLogs relationships

* Player event log viewer work

* More player event log work

* More player event work

* PLAYER_EVENT.REZ_ACCEPTED

* Update PlayerEventLogs.vue

* LogSettings

* [Occulus] Stop timer, dev process launch, info-error banner fixes

* Port over log streaming

* Cleanup zone log streaming

* Update Navbar.vue

* Run process management for Occulus when web service is booted

* eqemuserverapi

* Update hello_world_cmd.go

* EqemuAdminClient -> OcculusClient

* Log ui

* Move controllers to their domain boundary

* Hook up eqemuserverapi controller

* Change response struct

* Reload log settings in game

* Finish log settings

* Discord webhooks

* UI tweaks

* Hot reload management page

* Choose static zones from launcher options

* Update eqemuserverapi_controller.go

* Implement database backups

* Update LogSettings.vue

* Update ServerRules.vue

* Server reload api

* Update LogSettings.vue

* Update LogSettings.vue

* Update QuestHotReload.vue

* Player event log settings

* Bulk loading

* More filters

* Update PlayerEventLogs.vue

* More work

* Explorer work

* Loading, raw expansion

* UI wrap

* Count endpoint for pagination

* Pagination

* Add count endpoint to code generation

* UI tweaks

* Trade event render

* More UI work

* Handin events

* Update PlayerEventDisplayComponent.vue

* Update occulus_controller.go

* Update eq-ui.css

* Tweaks

* Telnet client hardening

* Fetch Occulus binary from FS when release request fails

* Nil check

* Nil check since switching to pointer

* Update app-env.ts

* Avatar fix

* Connection active fix

* Default local

* Connection delete fix

* Reload on delete

* Connection tweaks

* CSS tweals

* UI tweaks

* Update EQSpellPreviewTable.vue

* Add whereJson support

* Filters

* Add event filters

* Tweaks

* Fix the rate limiter

* Add self built releases tab, tab selection component propogation

* Watch selection updates

* Fix zero state

* Add hack / killed events

* Add contains filters

* Update PlayerEventLogs.vue

* CSS tweaks

* Cleanup

* Server config controller work

* More nav work

* More nav work

* Update PlayerEventLogs.vue

* Misc tweaks

* Combine stderr / stdout

* Swap report check

* Server config work

* UCS

* Port zone server config

* Remove old config routes / views

* Update ServerConfig.vue

* Update DiscordCrashWebhook.vue

* Code gen

* Port message of the day

* Update Navbar.vue

* Wrap up Websocket proof of concept

* Websocket tweaking

* Rename eqemuserverapi to eqemuserver

* Move spireuser to spire

* websocketserver to websocket

* Websocket authentication, client

* Updater work

* Release installation

* Build streaming

* Build settings, progress streaming, cleaning

* Branch work

* Update eqemuserver_controller.go

* Finish server update

* Remove Occulus Server Code management

* Cross platform connection check

* Cross platform support work (Windows testing)

* Telnet hardening

* Update ServerReload.vue

* Dump hardware info for dashboard swap

* System endpoints

* Remove zone server dependency on Occulus (Spire native)

* Update ZoneServers.vue

* resource endpoints

* Header work

* Migrate dashboard counter stats to Spire

* Feed Server Processes card from admin header data feed

* Port dashboard

* Consolidate path management logic

* Port client file exports

* Port manual backups to Spire

* Cleanups

* Automate "days back" to last release, exclude notes found in previous release, exclude releases

* Add hotfix replacement back

* Coffee

* Fix changelog partial contains to exact

* More changelog generator consistency tweaks

* File log streaming

* Search filtering, watch timer etc

* Update FileLogs.vue

* Text formatting

* Add line buffers for rendering performance

* File deletion and filters

* Search all files

* Code complete

* Replace nav and old file logs

* Update SpireInitialize.vue

* Update FileLogs.vue

* Update FileLogs.vue

* Add localaddress address to config

* Preflight checks, http streaming client

* Cleanup

* Kbar

* Cleanup

* .

* Add autofocus to pages

* Update PlayerEventLogs.vue

* Admin permissions start

* Permission visual improvements

* Cleaning up bubbling up error messages

* More permission work

* More cleanup for permissions

* Tweak author formatting

* Keyboard shortcuts modal

* Add item creation event to renderer

* Detect when window blurs

* Remove duplicate groundspawn event renderer

* Handle task event renders

* Split money, task updates renders, server creation

* Trader purchase event

* Trader events

* Update FileLogs.vue

* More key work

* Update Navbar.vue

* Update Navbar.vue

* Bubble backup error

* Add image lazy loading to changlog, have changelog take up whole page width

* Min image height, changelog padding

* Fix state bug with players online

* Initial 3.0.0 release notes

* Update CHANGELOG.md

* Update lazy-image-load.ts

* Update CHANGELOG.md

* Fade in lazy image load

* Tweaks

* tweaks

* Update Home.vue

* Scroll to hash logic improve

* Cleanup database backups view

* Fix #107

* Address #106

* Fix #104

* Fix #92

* Address #95

* Address #91

* Add tab deep linking to item editor

* Add tab deep linking to spell editor

* Fix extradmgskill, skillmodtype zero value display

* Fix #100

* Implement #98 and cleanup state logic for QuestApiExplorer

* Fix #83

* Update NpcSpellListEditor.vue

* Update changelog

* Update CHANGELOG.md

* Update clipboard.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants