Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pacmog no-alloc #49

Closed
wants to merge 3 commits into from
Closed

Conversation

kevinclark
Copy link

As great as anyhow is, it requires a global allocator. Since pacmog is targeted towards embedded systems, requiring alloc limits its adoption. Doing that for an error framework seems like an awkward tradeoff. This PR replaces anyhow with embeded_error_chain which is no-std and no-alloc.

Totally understand this is an unsolicited and somewhat large change. I need it for my use, so I'll maintain it on my own if I need to. Seemed like a reasonable speculative change though given pacmog's positioning.

@AkiyukiOkayasu
Copy link
Owner

anyhow is not suitable for pacmog, I agree with that.
I think error_in_core will be stable in Rust v1.81, so I'll leave error handling alone for now.
It may be replaced when thiserror becomes available in no_std.

@AkiyukiOkayasu
Copy link
Owner

Resolved in #52 . it should be noted that Rust 1.81 or later is required. Not yet published on crate.io (there is still some work to do).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants